Repository navigation
Document create and update rejection messages - #98
Merged
dmccoystephenson merged 1 commit intoNov 16, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (PR #98):
Inline-style notes:
The rubric found no FAIL items. Because a docs-only diff gives the reviewer little to check, each quoted message was verified against both the source string and its test assertion ( This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
dmccoystephenson
deleted the
feat/document-create-update-rejection-messages
branch
November 16, 2026 05:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Stage A documentation sweep found that
README.mdquotes the exact message for most rejections, but not for thecreateandupdaterejections listed below. Those messages have now been added:create(CreateProjectCommand.execute): the name-taken messageProject name '<project-name>' is already taken. Please choose a different name., andProject name cannot be empty./Project description cannot be empty.for an empty or whitespace-only name or description.update(UpdateProjectCommand.execute):Nothing to update. Provide at least one of --description, --impact, --confidence, --ease, --reach or --effort.,Project description cannot be empty.andAll scores must be between 1 and 5.These are now listed as bullets. It is also stated that the options are checked before the project is looked up, soupdatewith no options reportsNothing to updateeven for a name that no project has. This follows the order of the checks inUpdateProjectCommand.execute.Each quoted message was compared word for word against the source string and the test that asserts it (
CreateProjectCommandTest:212,229,353,UpdateProjectCommandTest:122,135,162).No tracking issue: these gaps were found during the sweep.
Skipped this cycle: #27 (controller endpoints) stays deferred. Its design questions are still open, and it would add a web dependency to
build.gradle, which is on the do-not-auto-merge list. The reasons are already recorded on the issue.Test plan
./gradlew teston JDK 21: 195 tests, 0 failures, 0 errors, 0 skipped (counted frombuild/test-results/test/*.xml)This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson